feat!: rework Avatar, User and UserLabel components #1991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
|
Visual Tests Report is ready. |
amje
requested changes
Dec 13, 2024
DakEnviy
force-pushed
the
feat/new-avatar-sizes
branch
from
9c488e7 to
4c23e0b
Compare
DakEnviy
changed the title
DakEnviy
force-pushed
the
feat/new-avatar-sizes
branch
2 times, most recently
from
387a2ec to
b6b7654
Compare
DakEnviy
force-pushed
the
feat/new-avatar-sizes
branch
from
b6b7654 to
c2dec6b
Compare
korvin89
reviewed
Dec 18, 2024
| &__icon { | ||
| color: var(--g-avatar-color, var(--_--color)); | ||
|
|
||
| & > svg { |
There was a problem hiding this comment.
Why we need it? Looks unreliable
| @@ -1,6 +1,7 @@ | |||
| @use 'sass:map'; | |||
|
|
|||
| $sizes: ( | |||
| '3xs': 16px, | |||
| '2xs': 20px, | |||
| 'xs': 24px, | |||
| 's': 28px, | |||
There was a problem hiding this comment.
I thought that we wanted to change this sizes like in Button?
amje
reviewed
Dec 18, 2024
| | `--g-user-line-height` | Name and description line height | | ||
| | Name | Description | | ||
| | :--------------------------------- | :-------------------------------- | | ||
| | `--g-user-gap` | Gap between avatar and text block | |
There was a problem hiding this comment.
What about --g-user-avatar-offset name for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: DATAUI-2913
Breaking changes
Avatar
imgUrl,iconortextssize2xssizeUser
msizexlsizeUserLabel
childrenproperty withtextFeatures
Avatar
3xssizeAriaLabelingProps--g-avatar-border-width,--g-avatar-inner-border-widthand--g-avatar-font-weightto CSS APIUser
3xssizeAriaLabelingPropsUserLabel
3xsand2xssizesdescriptionproperty